Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use preformatted_text color for rendering plain text files #351

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

seifferth
Copy link
Contributor

Using a color from the theme should make the rendering of text files be more in line with the colors chosen for styled content. Furthermore, allowing some form of user override for the color of plain text files allows users to individually fix bad color combinations. Such as in my case, where the combination of a solarized terminal theme and the default color chosen by amfora causes plain text files to be rendered as white text on an almost equally bright background.

Using a color from the theme should make the rendering of text
files be more in line with the colors chosen for styled content.
Furthermore, allowing some form of user override for the color
of plain text files allows users to individually fix bad color
combinations. Such as in my case, where the combination of a
solarized terminal theme and the default color chosen by amfora
causes plain text files to be rendered as white text on an almost
equally bright background.
@makew0rld
Copy link
Owner

Such as in my case, where the combination of a solarized terminal theme and the default color chosen by amfora causes plain text files to be rendered as white text on an almost equally bright background.

Can you explain more about this issue? Why doesn't it occur when browsing gemtext files?

@seifferth
Copy link
Contributor Author

seifferth commented Oct 24, 2024 via email

@makew0rld
Copy link
Owner

Makes sense, thanks.

@makew0rld makew0rld merged commit 1115614 into makew0rld:master Dec 18, 2024
2 of 3 checks passed
makew0rld added a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants