don't catch browser provider error too early

makerdao · Oct 11, 2018 · b075eac · b075eac
1 parent 00e0050
commit b075eac
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/src/eth/accounts/setup.js b/src/eth/accounts/setup.js
@@ -33,11 +33,7 @@ export async function getBrowserProvider() {
   };
 
   if (window.ethereum) {
-    try {
-      await window.ethereum.enable();
-    } catch (error) {
-      console.error(error);
-    }
+    await window.ethereum.enable();
     return wrap(window.ethereum);
   } else if (window.web3) {
     return wrap(window.web3.currentProvider);

diff --git a/test/eth/AccountsService.spec.js b/test/eth/AccountsService.spec.js
@@ -167,13 +167,16 @@ describe('mocking window', () => {
 
   test('browserProviderAccountFactory with window.ethereum, user rejects provider', async () => {
     window.ethereum = {
-      enable: () => {
+      enable: async () => {
         window.ethereum['sendAsync'] = mockProvider.sendAsync;
-        throw new Error();
+        throw new Error('nope');
       }
     };
-    global.console = { error: jest.fn() };
-    await browserProviderAccountFactory();
-    expect(console.error).toBeCalled();
+    expect.assertions(1);
+    try {
+      await browserProviderAccountFactory();
+    } catch (err) {
+      expect(err.message).toMatch(/nope/);
+    }
   });
 });