A critical fix of library crash and control sequence handling (\n) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| // Remove the weak pointer to the callback | ||
| m_callbacks.erase(i); |
There was a problem hiding this comment.
Good catch! I have cherry picked this over to our release candidate branch for now, and will look over the rest of this pull request later. We switched over to git flow a while back, so the rest of this will have to go into develop until our next release, and there are a few changes both there and in a feature branch that we are about to merge to develop that will likely conflict with the whitespace parsing changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was deletion of m_callbacks.end() when receiving "parse error" string, that lead to segfault of the app.
Also, a single \n, or a \n at the end of the json string was triggering json parsing one more time.
sometimes, under severe load (millions requests per hour) and unstable transmission line you can run into loss of synchronization of the stream. JSON stream parsing state machine adds '{' to stack, but end sequence of } can be lost. That leads to endless stream bufferization in parser. To avoid this, a delimiter was implemented, that resets stream parser to initial state after. If delimiter is not used, it can be set to \0