Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for multi-framework package publish #58

Merged
merged 24 commits into from
May 2, 2024
Merged

Conversation

davidatwhiletrue
Copy link
Member

Summary

  • Added compat extensions to test against net7.0 and netstandard2.0
  • Adjust test pipelines to test both frameworks
  • Adjust build pipeline to create a nuget package with both targets.

TODO

Checklist

  • Code is properly formatted
  • All commits are signed
  • Tests included/updated or not needed
  • Documentation (manuals or wiki) has been updated or is not required

Andrzej Broński and others added 24 commits August 30, 2023 17:51
It solves CS8370.

Signed-off-by: Andrzej Broński <[email protected]>
It solves CS0234.

Signed-off-by: Andrzej Broński <[email protected]>
It solves CS0518.

Signed-off-by: Andrzej Broński <[email protected]>
It solves CS0234.

Signed-off-by: Andrzej Broński <[email protected]>
It solves CS0246.

Signed-off-by: Andrzej Broński <[email protected]>
It solves CS0518.

Signed-off-by: Andrzej Broński <[email protected]>
It solves CS7036.

Signed-off-by: Andrzej Broński <[email protected]>
It solves CS7036.

Signed-off-by: Andrzej Broński <[email protected]>
It solves CS1501.

Signed-off-by: Andrzej Broński <[email protected]>
It solves CS1501.

Signed-off-by: Andrzej Broński <[email protected]>
Signed-off-by: Andrzej Broński <[email protected]>
It solves CS7036.

Signed-off-by: Andrzej Broński <[email protected]>
It solves CS0117.

Signed-off-by: Andrzej Broński <[email protected]>
Signed-off-by: Andrzej Broński <[email protected]>
Before it was `Content-Type: application/json; charset`, which caused error "415 Unsupported Media Type".

Signed-off-by: Andrzej Broński <[email protected]>
[Feature] Compatibility with Unity - netstandard2.0 target
# Conflicts:
#	Casper.Network.SDK/Casper.Network.SDK.csproj
Signed-off-by: David Hernando <[email protected]>
fix xml documentation location

Signed-off-by: David Hernando <[email protected]>
@@ -2,7 +2,7 @@ name: Build and Test

on:
push:
branches: [ master ]
branches: [ master, netstandard-2-0-target ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this branch gonna be permanent?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it won't be needed. All this PR is to have one single pipeline to build, test and publish for two platforms, .NET and netstandard2.0.

Copy link
Member

@mrkara mrkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mrkara mrkara merged commit f69e90e into master May 2, 2024
7 checks passed
@mrkara mrkara deleted the netstandard-2-0-target branch May 2, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants