Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update messages serialization RC5 #127

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Update messages serialization RC5 #127

merged 4 commits into from
Dec 20, 2024

Conversation

ZhmakAS
Copy link
Collaborator

@ZhmakAS ZhmakAS commented Dec 19, 2024

Update messages serialization

  • Resolves: #

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • All commits are signed
  • Tests included/updated or not needed
  • Documentation (manuals or wiki) has been updated or is not required

@ZhmakAS
CSDK/update_message_serialization
b850a1c 
Update messages serialization
@davidatwhiletrue
Copy link
Member

The key MessageAddr also needs to be updated to replace EntityAddr with HashAdd.
Like here: https://github.com/make-software/casper-net-sdk/pull/86/files#diff-21712b67ff1554def1e81212a35072134c78aca6490f2d29fe8743f9bb921952

davidatwhiletrue
davidatwhiletrue requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@davidatwhiletrue davidatwhiletrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZhmakAS see my comment.

@ZhmakAS
CSDK/update_message_serialization
2cb44fb 
Update message key parsing
davidatwhiletrue
davidatwhiletrue approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@davidatwhiletrue davidatwhiletrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ihor ihor merged commit a33bbd4 into master Dec 20, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidatwhiletrue davidatwhiletrue davidatwhiletrue approved these changes

@ihor ihor ihor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZhmakAS @davidatwhiletrue @ihor