Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple inclusion of module #18

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Allow multiple inclusion of module #18

merged 1 commit into from
Nov 27, 2023

Conversation

EisenMax
Copy link
Contributor

@EisenMax EisenMax commented Sep 8, 2023

No description provided.

@EisenMax
Copy link
Contributor Author

EisenMax commented Sep 8, 2023

Da wäre die Version 2.1.2.

@EisenMax EisenMax requested a review from foobear September 8, 2023 12:49
foobear
foobear reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@foobear foobear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good, thank you. I think we can improve the test a bit.

Please also update CHANGELOG.md in the "Unreleased" section.

We will increment the gem's version in a separate commit where we will also move contents from "Unreleased" into a section for the new version.

spec/rails_state_machine/model_spec.rb Outdated Show resolved Hide resolved
@EisenMax EisenMax requested a review from foobear September 8, 2023 15:22
foobear
foobear requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@foobear foobear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update CHANGELOG.md in the "Unreleased" section.

@EisenMax EisenMax force-pushed the me/allow-multiple-inclusion-185804131 branch from 3aade32 to 860179d Compare September 14, 2023 11:27
@EisenMax EisenMax requested a review from foobear September 14, 2023 11:57
foobear
foobear requested changes Nov 15, 2023
View reviewed changes
Copy link
Member

@foobear foobear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the Unreleased section in CHANGELOG.md and don't update the version.rb yet.

We currently have different unreleased changes and they should not try to assume a version number yet.

Version and changelog will be adjusted when we actually release.

@EisenMax EisenMax force-pushed the me/allow-multiple-inclusion-185804131 branch from 860179d to 876003b Compare November 23, 2023 13:15
@EisenMax EisenMax requested a review from foobear November 24, 2023 12:03
@EisenMax EisenMax merged commit 876003b into master Nov 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foobear foobear foobear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EisenMax @foobear