updating nmea_proxy to support fowarding to a secondary destination like Avalon #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ike Avalon router
toxcct
reviewed
Jun 15, 2021
|
the best would be to write connection nmea 1 and connection nmea 2
----- Mail original -----
De: "toxcct" ***@***.***>
À: "mak08/VRDashboard" ***@***.***>
Cc: "Subscribed" ***@***.***>
Envoyé: Mercredi 16 Juin 2021 01:03:55
Objet: Re: [mak08/VRDashboard] updating nmea_proxy to support fowarding to a secondary destination like Avalon (#44)
@toxcct commented on this pull request.
Many lines mention the Avalon router.
Should we keep mention of a specific router name in the Dashboard, which is, AFAIK, not dedicated to a single router app/device ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub , or unsubscribe .
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is provided to you by EffectiveTeam. It enables both Avalon and QTVlm routers to get NMEA data simultaneously from VRDashboard.
Without this enhancement, only 1 can receive data from VRDashboard ; on the other, boat position is painfully updated manually.
Carefull attention has been paid to not disturb current nmea_proxy.py behaviour.
In order to enable the new feature and forward data to Avalon, simply use the new "--fport <fowarding_port>" option and set accordingly this forwarding port on Avalon race setting as NMEA source.
Proper logging and error management has been included.
Code has been tested successfully in various configuration.