fix possibly leaking eventlisteners (shoelace-style#2257)

majidalfuttaim · Nov 19, 2024 · 1898072 · 1898072
1 parent 9a4a709
commit 1898072
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/components/dialog/dialog.component.ts b/src/components/dialog/dialog.component.ts
@@ -114,7 +114,7 @@ export default class SlDialog extends ShoelaceElement {
     super.disconnectedCallback();
     this.modal.deactivate();
     unlockBodyScrolling(this);
-    this.closeWatcher?.destroy();
+    this.removeOpenListeners();
   }
 
   private requestClose(source: 'close-button' | 'keyboard' | 'overlay') {

diff --git a/src/components/drawer/drawer.component.ts b/src/components/drawer/drawer.component.ts
@@ -131,7 +131,7 @@ export default class SlDrawer extends ShoelaceElement {
   disconnectedCallback() {
     super.disconnectedCallback();
     unlockBodyScrolling(this);
-    this.closeWatcher?.destroy();
+    this.removeOpenListeners();
   }
 
   private requestClose(source: 'close-button' | 'keyboard' | 'overlay') {