Fix compatibility with very old and very new versions of Perl #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannessen
force-pushed
the
compat-perl
branch
2 times, most recently
from
cde8c67 to
1004584
Compare
REST::Neo4p 0.4000+ requires HTTP::Tiny, which was first released with Perl v5.13.9. This change adds it to the required modules for compatibility with earlier versions of Perl. Mojo::Exception was only used in a single test, and that test is currently skipped by default. So there's currently no reason to force users to install Mojolicious.
JSON::XS has been failing to install on blead Perl for half a year (v5.41). It doesn't seem like a good idea to depend upon it. JSON::MaybeXS is a modern replacement for JSON.pm. It can use JSON::XS and JSON::PP when available, but actually prefers Cpanel::JSON::XS, which is a long-proven and well-maintained fork of JSON::XS. JSON::MaybeXS was already an indirect prerequisite to REST::Neo4p because Neo4j::Driver depends upon it. JSON::ize did, too; but although JSON::ize was a declared prerequisite, it's actually unused in REST::Neo4p.
johannessen
force-pushed
the
compat-perl
branch
from
1004584 to
53d8ecd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rest::Neo4p declares Perl v5.10.1 as the minimum required version. But the tests actually tend to fail on versions earlier than v5.14.
Rest::Neo4p uses the
smartmatchfeature, which issues warnings on Perl v5.38 and v5.40. (#35)Rest::Neo4p declares several dependencies on modules that are outdated and have better drop-in alternatives, or modules that aren’t actually used at all. This can cause unnecessary problems if those other modules don’t install cleanly for whatever reason.
These changes should make REST::Neo4p work well on all Perl versions from v5.10.1 through v5.40 and beyond.