Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide horizontal scrollbar in StartPrintDialog.vue #2075

Merged

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Dec 9, 2024

Description

This PR hide the horizontal scrollbar in the StartPrintDialog, but the vertical scrollbar is still untouched and can be visible, when the window is too small.

Related Tickets & Documents

none

Mobile & Desktop Screenshots/Recordings

before:
image

after:
image

[optional] Are there any post-deployment tasks we need to perform?

none

@meteyou meteyou requested review from dw-0, rackrick and mryel00 December 9, 2024 19:44
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 9, 2024
Copy link
Member

@rackrick rackrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't even manged to get the horizontel scroll bar on the non fixed version ^^

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 17, 2024
@meteyou meteyou merged commit ea1dd67 into mainsail-crew:develop Dec 17, 2024
10 checks passed
@meteyou meteyou deleted the fix/start-print-dialog-scrollbars branch December 17, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants