Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Webcam): make webcam view non-draggable #2057

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Nov 28, 2024

Description

This PR makes the <img> tags created by the webcam preview non-draggable. They were draggable before, which would (at least in my case) lead to accidentally dragging it and uploading it to the config folder using the drag and drop function.
I was only able to test the Mjpegstreamer and MjpegstreamerAdaptive, so I didn't modify any of the other views.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 28, 2024
@phm07 phm07 changed the title fix: make webcam view non-draggable fix(Webcam): make webcam view non-draggable Nov 28, 2024
@meteyou
Copy link
Member

meteyou commented Nov 28, 2024

Thx for your PR! I just added the UV4LMJPEG client, because this mode also use an img-tag.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 28, 2024
@meteyou meteyou merged commit 0758af1 into mainsail-crew:develop Nov 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants