Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix color picker for PCA9632 #2028

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Oct 15, 2024

Description

This PR fix the color picker for PCA9632.

Related Tickets & Documents

fixes #2022

Mobile & Desktop Screenshots/Recordings

none

[optional] Are there any post-deployment tasks we need to perform?

none

Summary by Sourcery

Bug Fixes:

  • Fix the color picker functionality for PCA9632 by correcting the handling of the color_order setting.

@meteyou meteyou requested review from dw-0 and rackrick October 15, 2024 19:08
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 15, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @meteyou - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide more context in the PR description about the specific issue this change is addressing and how it resolves the problem with the color picker for PCA9632.
  • Consider adding a comment in the code to explain why we're now using the entire color_order array if the first element is falsy. This will help future maintainers understand the rationale behind this change.
  • Be cautious about potential side effects of using the entire color_order array. Ensure that this change doesn't break any assumptions in other parts of the code that might expect color_order to be a single character. Consider adding type checks or assertions if necessary.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

src/store/printer/getters.ts Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 7, 2024
@meteyou meteyou merged commit ae7f8f1 into mainsail-crew:develop Nov 7, 2024
11 checks passed
@meteyou meteyou deleted the fix/fix-color-picker-pca9632 branch November 7, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color Picker not displaying for PCA9632 with no pins specified
2 participants