Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix image viewer if the image is wider than the viewport #2020

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Sep 24, 2024

Description

This PR fix only the max-width from the imageviewer and fit the image to the current viewport.

Related Tickets & Documents

none

Mobile & Desktop Screenshots/Recordings

none

[optional] Are there any post-deployment tasks we need to perform?

none

Summary by Sourcery

Fix the image viewer component to handle images wider than the viewport by adjusting the max-width style property.

Bug Fixes:

  • Fix image viewer to ensure images wider than the viewport are properly scaled to fit within the current viewport.

@meteyou meteyou requested review from dw-0 and rackrick September 24, 2024 18:15
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 24, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @meteyou - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 4, 2024
@meteyou meteyou merged commit 58d4a2a into mainsail-crew:develop Nov 5, 2024
13 checks passed
@meteyou meteyou deleted the fix/fix-fullscreen-image branch November 5, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants