Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HistoryPanel): Fix History thumbnails of files in folders #2010

Merged

Conversation

mdziekon
Copy link
Contributor

Description

Fixes missing thumbnails in History page for files placed in non-root folders.

Bonus: refactors thumbnails url generation code so that it is reused for both small & big thumbnails, and improves TypeScript coverage by eliminating unwanted any usage.

Related Tickets & Documents

#2009

Mobile & Desktop Screenshots/Recordings

Before

obraz

After

obraz

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 13, 2024
Copy link
Member

@meteyou meteyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i only suggested one small comment/change, otherwise the code looks good. thanks for the PR!

src/components/panels/History/HistoryListEntryJob.vue Outdated Show resolved Hide resolved
src/components/panels/History/HistoryListEntryJob.vue Outdated Show resolved Hide resolved
src/components/panels/History/HistoryListEntryJob.vue Outdated Show resolved Hide resolved
@mdziekon mdziekon requested a review from meteyou September 15, 2024 10:00
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 15, 2024
@meteyou meteyou merged commit 2a49060 into mainsail-crew:develop Sep 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants