feat: Connect to Moonraker via subdirectory/path #1836
Conversation
|
Language file analysis report:
|
|
Language file analysis report:
|
4cello
changed the title
|
Thanks for your PR! Can you only remove the "advanced" accordion in the interface settings dialog and just display path per default with the default value "/"?
EDIT: this dialog is not visible when moonraker is the instance DB. so the small dialog should fit. |
|
Will do! What are your thoughts on the accordion in the small dialog? I don't love the look of it in general, but I also think it's good to hide an option which most people don't want to change anyways. |
|
to be honest, i personally don't like this function at all... maybe you could add a button at the bottom left next to the delete button to show/hide the advanced options? |
|
I think it could work, but I'm struggling to find a good icon. The good ol' Expand/Collapse just doesn't feel right when it's below the thing that it controls, and I also think it looks better if there's no text required.
|
|
Language file analysis report:
|
|
Language file analysis report:
|
|
Language file analysis report:
|
|
ok. i think i found an issue, when you try to connect to a printer without sub path: |
…and trailing slashes, then adding back a single slash if resulting path is non-empty
|
Language file analysis report:
|
|
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
|
Language file analysis report:
|
|
@4cello i added also the feature to use the prefix via config.json (without multi instances) and .env. please doublecheck this commit. |
Signed-off-by: Stefan Dej <[email protected]>
|
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
|
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
|
Language file analysis report:
|
Description
This allows to connect to moonraker instances on non-root paths, e.g.
all-printers.net/myprinter.This was already possible by appending the path to the port:
7125/myprinter, which is hacky and non-intuitive.I added an optional field "path" to the printers. The text fields are hidden in subpanels in
SelectPrinterDialogandSettingsPrinterRemoteTab. The only input validation currently is to check that the path starts with a "/", which is in line with validation rules for the hostname.Things I don't know if they're necessary or how to do (yet)
Related Tickets & Documents
Addresses #1599 as well as @PSandro's comment on #1163
Mobile & Desktop Screenshots/Recordings
[optional] Are there any post-deployment tasks we need to perform?