-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add confirmation dialog to cooldown button #1808
feat: Add confirmation dialog to cooldown button #1808
Conversation
Language file analysis report:
|
Language file analysis report:
|
Language file analysis report:
|
Language file analysis report:
|
and remove "info color" toolbar, fix icon and add also the dialog to the presets dropdown cooldown button. Signed-off-by: Stefan Dej <[email protected]>
Language file analysis report:
|
…tion Signed-off-by: Stefan Dej <[email protected]>
Language file analysis report:
|
sry for the long delay. i saw in your PR that the e-stop dialog is fullscreen. i think this should not be fullscreen and i created a PR to fix this (#1816). i also adapted your PR to this, removed the blue toolbar, changed the icon to the cooldown icon and merged it in your PR. but nonetheless. thanks for your PR! |
Yeah, I saw the full screen but I check the other confirmations and it was the same for them so I decided not to touch this |
You are welcome to create PRs if you have a good idea to add to Mainsail. Only panels like probe_calibrate, which contain a lot of content, should be fullscreen. Simple questions like "Are you sure?" are sufficient for a small dialog. |
Description
This PR adds the feature confirmation dialog to "COOLDOWN" button. (same looking dialog as the "Emergency Stop")
Related Tickets & Documents
no issue number, too many times I clicked this button by mistake.
Mobile & Desktop Screenshots/Recordings
[optional] Are there any post-deployment tasks we need to perform?
no