fix: fix long initial time with huge print history #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
|
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
|
Language file analysis report:
|
rackrick
reviewed
Dec 30, 2023
rackrick
reviewed
Dec 30, 2023
rackrick
reviewed
Dec 30, 2023
Signed-off-by: Stefan Dej <[email protected]>
Co-authored-by: rackrick <[email protected]>
|
Language file analysis report:
|
1 similar comment
|
Language file analysis report:
|
rackrick
approved these changes
Dec 30, 2023
|
Thanks for completing this, excited to try it out. Happy 2024! |
|
Issue seems to be mostly solved now. Now it takes no longer than 8 seconds which is a massive improvement over 15-30 seconds previously. Looking at the natwork traffic, 2 seconds is for the css file. So I'm assuming thst gets dynamically generated? |
|
@jLynx no... All files are static. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix a issue with long initial times with huge print histories. It only loads the first 100 entries and the rest only when the user clicks on a button.
Related Tickets & Documents
fixes #1468
Mobile & Desktop Screenshots/Recordings
none
[optional] Are there any post-deployment tasks we need to perform?
none