feat: Improve contrast of job queue items count #1678
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Job queue tab has a counter displaying current items count. The counter itself works fine, however it's presented as a gray text, which blends with the background and neighboring text. This quite poor contrast might lead to poor reception of the counter functionality (eg. for me, I usually forget that I've put something in the queue, because the counter is nearly indistinguishable from the tab's label).
To improve the "contrast" (so to speak) of the feature, a simple Badge component can be used instead of text interpolation with the tab's title, allowing it to be displayed slightly different than the neighboring text (the "contrast" improvement comes mainly from the different element being used rather than just color change). This approach also allows it to change its background depending on how many items we've placed in the queue (
gray
for0
,blue
for1+
;blue
chosen as information color).This proposal (in a form of a ready made Pull Request) implements this change and cleans up any localisation files from previous interpolation formatting.
Related Tickets & Documents
N/A
Mobile & Desktop Screenshots/Recordings
Before:
After:
[optional] Are there any post-deployment tasks we need to perform?
No