feat: add settings for public url of the spoolman frontend #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Language file analysis report:
|
|
Language file analysis report:
|
|
@Roguyt Thx for your PR! Would it be also possible to just replace 127.0.0.1/localhost with the current moonraker connection host? |
|
Ahoi! It looks like there hasn't been any recent updates on Fair wind and a following sea! PS: I'm just an automated script, not a real sailor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allow to specify the real IP or domain of the spoolman client which is used in the Mainsail UI to open it through the two buttons "Open Spool Manager"
This resolves an issue I have since my spoolman instance is set as 127.0.0.1 for moonraker but this isn't obviously the good link to access the Web UI.
Mobile & Desktop Screenshots/Recordings
[optional] Are there any post-deployment tasks we need to perform?
No.