Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add optional background color for big gcode thumbnails #1535

Merged
merged 5 commits into from
Oct 7, 2023
Merged

feat: add optional background color for big gcode thumbnails #1535

merged 5 commits into from
Oct 7, 2023

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Aug 27, 2023

Description

This PR adds a optional background color to gcode thumbnails.

Related Tickets & Documents

fixes: #1507

Mobile & Desktop Screenshots/Recordings

Start print dialog:
image

Status panel:
image

Gcode list:
image

Settings:
image

[optional] Are there any post-deployment tasks we need to perform?

none

@meteyou meteyou requested review from dw-0 and rackrick August 27, 2023 11:14
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

dw-0
dw-0 requested changes Aug 27, 2023
View reviewed changes
src/locales/en.json Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

@meteyou meteyou mentioned this pull request Aug 30, 2023
Closed
@EmJay276
Copy link
Contributor

EmJay276 commented Sep 4, 2023

Is it possible to add an "autodetection" of the background color based on the image color?
Dark picture => light background
Bright picture => dark background

@meteyou
Copy link
Member Author

meteyou commented Sep 4, 2023

@EmJay276 i don't think so and/or i don't see a benefit to add a huge lib to detect the image for such a small use-case...

@EmJay276
Copy link
Contributor

EmJay276 commented Sep 4, 2023

@meteyou
This here seems to work without a big library
https://stackoverflow.com/questions/38211798/detect-if-image-is-dark-light-and-addclass-dark-light-to-parent

@meteyou
Copy link
Member Author

meteyou commented Sep 16, 2023

@EmJay276 hmm... that could work, but is a a bigger rework. can you please open a new FR with this link? so i can add this for the next release. for this release, i would just merge this PR and extend it with the next one.

@meteyou meteyou requested a review from dw-0 September 16, 2023 09:27
@meteyou
Merge branch 'develop' into feat/background-color-thumbnails
80959c6 
# Conflicts:
#	src/components/dialogs/StartPrintDialog.vue
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

@meteyou meteyou merged commit 82e3dd8 into mainsail-crew:develop Oct 7, 2023
9 checks passed
@meteyou meteyou deleted the feat/background-color-thumbnails branch October 7, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dw-0 dw-0 dw-0 approved these changes

@rackrick rackrick Awaiting requested review from rackrick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Choose image background color based on color of the thumbnail content
3 participants
@meteyou @EmJay276 @dw-0