feat(move): implement #1209 #1524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Language file analysis report:
|
|
Language file analysis report:
|
|
Language file analysis report:
|
|
Language file analysis report:
|
|
Sorry for the late response. I think you misunderstood the FR. In this PR, you added the "rename" function with new names again. But the user wanted to select several files and move these simultaneously to different directory. In the background, the Moonraker "move" API is used, but it should not change the name but the location. |
|
i will close this PR, because of no response... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the feature reqested in FR #1209.
Code is recycled from "rename" function, properly relabelled to improve UX.
The feature impact ConfigFilePanel, GCodeFilePanel and Status/GcodefilesPanel
Related Tickets & Documents
Fixes #1209
Mobile & Desktop Screenshots/Recordings
Desktop view GCode Files
Desktop view Config Files
Mobile view GCode Files
Mobile view Config Files
Move-to Dialog
[optional] Are there any post-deployment tasks we need to perform?