-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to pnpm #2570
Move to pnpm #2570
Conversation
1102b16
to
b2c51cc
Compare
f8500b8
to
c3def38
Compare
22376b5
to
e3ea2fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d suggest keeping Volta - that has beta pnpm support now
a83020f
to
1ec7d8d
Compare
@marcoow It'd seem that this volta issue is blocking volta-cli/action#121 It doesn't seem to me that the experimental support is worth the hassle of figuring it out. |
We're using it in Gravity and (I think) it works quite well – https://github.com/mainmatter/gravity/blob/master/.github/workflows/ci.yml |
1faeb20
to
9d99364
Compare
|
Merged since it seems like I've cleared out the concerns, I'd like to see if renovate works correctly and so we can merge new package versions without the need to manually maintain lock files in this PR anymore. |
Note:
ember-release
scenario should start passing after #2565