Skip to content

Commit

Permalink
Fixed an issue with Exception handling.
Browse files Browse the repository at this point in the history
  • Loading branch information
Travis Swientek committed Aug 21, 2013
1 parent 56b5057 commit f8babb0
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?php
namespace Mailgun\Connection\Exceptions;

class MissingRequiredParameters extends \Exception{}

?>
4 changes: 2 additions & 2 deletions src/Mailgun/Connection/RestClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use Mailgun\Connection\Exceptions\GenericHTTPError;
use Mailgun\Connection\Exceptions\InvalidCredentials;
use Mailgun\Connection\Exceptions\NoDomainsConfigured;
use Mailgun\Connection\Exceptions\MissingRequiredMIMEParameters;
use Mailgun\Connection\Exceptions\MissingRequiredParameters;
use Mailgun\Connection\Exceptions\MissingEndpoint;

/*
Expand Down Expand Up @@ -83,7 +83,7 @@ public function responseHandler($responseObj){
$result->http_response_body = $jsonResponseData;
}
elseif($httpResponeCode == 400){
throw new MissingRequiredMIMEParameters(EXCEPTION_MISSING_REQUIRED_MIME_PARAMETERS);
throw new MissingRequiredParameters(EXCEPTION_MISSING_REQUIRED_PARAMETERS);
}
elseif($httpResponeCode == 401){
throw new InvalidCredentials(EXCEPTION_INVALID_CREDENTIALS);
Expand Down
2 changes: 1 addition & 1 deletion src/Mailgun/Constants/Constants.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
//Common Exception Messages
const EXCEPTION_INVALID_CREDENTIALS = "Your credentials are incorrect.";
const EXCEPTION_GENERIC_HTTP_ERROR = "An HTTP Error has occurred! Check your network connection and try again.";
const EXCEPTION_MISSING_REQUIRED_MIME_PARAMETERS = "The parameters passed to the API were invalid. This might be a bug! Notify [email protected].";
const EXCEPTION_MISSING_REQUIRED_PARAMETERS = "The parameters passed to the API were invalid. This might be a bug! Notify [email protected].";
const EXCEPTION_MISSING_ENDPOINT = "The endpoint you've tried to access does not exist. This might be a bug! Notify [email protected].";
const TOO_MANY_RECIPIENTS = "You've exceeded the maximum recipient count (1,000) on the to field with autosend disabled.";
const INVALID_PARAMETER_NON_ARRAY = "The parameter you've passed in position 2 must be an array.";
Expand Down

0 comments on commit f8babb0

Please sign in to comment.