Revise domain creation assertions and add tests

Based on feedback from @DavidGarciaCat.
mailgun · Aug 29, 2019 · 2db0619 · 2db0619
1 parent c9bbf8e
commit 2db0619
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/src/Api/Domain.php b/src/Api/Domain.php
@@ -90,12 +90,11 @@ public function create(string $domain, string $smtpPass = null, string $spamActi
 
         if (!empty($smtpPass)) {
             Assert::stringNotEmpty($smtpPass);
-            Assert::lengthBetween($smtpPass, 5, 32, 'SMTP password must be between 5 and 32 characters.');
 
             $params['smtp_password'] = $smtpPass;
         }
 
-        if (null !== $spamAction) {
+        if (!empty($spamAction)) {
             // TODO(sean.johnson): Extended spam filter input validation.
             Assert::stringNotEmpty($spamAction);
 

diff --git a/tests/Api/DomainTest.php b/tests/Api/DomainTest.php
@@ -85,13 +85,43 @@ public function testCreate()
     }
 
     public function testCreateWithPassword()
+    {
+        $this->setRequestMethod('POST');
+        $this->setRequestUri('/v3/domains');
+        $this->setRequestBody([
+            'name' => 'example.com',
+            'smtp_password' => 'foo',
+        ]);
+        $this->setHydrateClass(CreateResponse::class);
+
+        $api = $this->getApiInstance();
+        $api->create('example.com', 'foo');
+    }
+
+    public function testCreateWithPasswordSpamAction()
+    {
+        $this->setRequestMethod('POST');
+        $this->setRequestUri('/v3/domains');
+        $this->setRequestBody([
+            'name' => 'example.com',
+            'smtp_password' => 'foo',
+            'spam_action' => 'bar',
+        ]);
+        $this->setHydrateClass(CreateResponse::class);
+
+        $api = $this->getApiInstance();
+        $api->create('example.com', 'foo', 'bar');
+    }
+
+    public function testCreateWithPasswordSpamActionWildcard()
     {
         $this->setRequestMethod('POST');
         $this->setRequestUri('/v3/domains');
         $this->setRequestBody([
             'name' => 'example.com',
             'smtp_password' => 'foo',
             'spam_action' => 'bar',
+            'wildcard' => 'true',
         ]);
         $this->setHydrateClass(CreateResponse::class);