Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(gossipsub): make CI test to be more strict 0-tolerance for missed published messages #763

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

bochaco
Copy link
Contributor

@bochaco bochaco commented Sep 21, 2023

Description

Summary generated by Reviewpad on 21 Sep 23 21:05 UTC

This pull request includes the following changes:

  1. The addition of new message types for subscribing and publishing to a gossipsub topic in the safenode protocol.
  2. Import statements and new error variants related to publishing and subscribing in the error.rs file.
  3. Addition of new packages and dependencies related to futures and libp2p-gossipsub modules in the Cargo.toml file.
  4. Changes to the API functionality, including new methods for subscribing and publishing on gossipsub topics, and event handling for gossipsub messages in the api.rs file.
  5. Addition of the gossipsub behavior to the NodeBehaviour struct and initialization in the NetworkBuilder implementation.
  6. Code modifications related to subscribing and publishing to a gossipsub topic in the main.rs and other files.
  7. Addition of a new job called "gossipsub" for running Gossipsub E2E tests.
  8. Changes related to adding the "gossipsub" feature to the libp2p dependency in the Cargo.toml file.
  9. Addition of new RPC methods for subscribing and publishing on a gossipsub topic in the safenode.proto file.
  10. Updates to the ClientEvent and NodeEvent enums to include support for gossipsub messages.
  11. Introduction of support for handling gossipsub events and messages in the networking module.
  12. Addition of a new file and code for gossipsub management in the CLI tool.
  13. Changes related to managing gossipsub in the SubCmd enum and mod.rs file in the CLI tool.
  14. Addition of a new job called "gossipsub" and modifications in other jobs in a CI/CD pipeline configuration.
  15. Changes related to handling gossipsub messages in the event.rs file.
  16. Addition of test functions for Gossipsub functionality in different files.
  17. Addition of support for gossipsub management in the CLI application.
  18. Modifications in the sn_networking module to include methods for subscribing and publishing on gossipsub topics.
  19. Introduction of two new RPC methods for subscribing and publishing on gossipsub topics in a service file.

Let me know if you need further assistance with this code review.

@reviewpad reviewpad bot added the Large Large sized PR label Sep 21, 2023
@bochaco bochaco force-pushed the test-gossipsub-to-be-more-strict branch 2 times, most recently from 3ba7836 to c03a170 Compare September 25, 2023 12:53
@reviewpad reviewpad bot added Small Pull request is small and removed Large Large sized PR labels Sep 25, 2023
@bochaco bochaco force-pushed the test-gossipsub-to-be-more-strict branch 4 times, most recently from fcdac08 to 095a0e5 Compare September 25, 2023 17:55
@bochaco bochaco force-pushed the test-gossipsub-to-be-more-strict branch from 095a0e5 to 7713f45 Compare October 4, 2023 13:52
@reviewpad reviewpad bot added Medium Medium sized PR and removed Small Pull request is small labels Oct 4, 2023
@bochaco bochaco force-pushed the test-gossipsub-to-be-more-strict branch 3 times, most recently from 94fe0be to 894e86c Compare October 4, 2023 14:25
@bochaco bochaco marked this pull request as ready for review October 4, 2023 14:26
@reviewpad reviewpad bot requested a review from S-Coyle October 4, 2023 14:26
@bochaco bochaco force-pushed the test-gossipsub-to-be-more-strict branch 6 times, most recently from 097f05d to f417257 Compare October 4, 2023 15:49
@bochaco bochaco enabled auto-merge October 4, 2023 18:05
@bochaco bochaco disabled auto-merge October 4, 2023 18:24
@bochaco bochaco force-pushed the test-gossipsub-to-be-more-strict branch from f417257 to cfb77f3 Compare October 4, 2023 18:36
@bochaco bochaco enabled auto-merge October 4, 2023 18:37
@bochaco bochaco force-pushed the test-gossipsub-to-be-more-strict branch 2 times, most recently from bbb1a44 to fba46f0 Compare October 4, 2023 19:30
@bochaco bochaco force-pushed the test-gossipsub-to-be-more-strict branch 3 times, most recently from 0ce621a to aad73c3 Compare October 5, 2023 12:46
@bochaco bochaco force-pushed the test-gossipsub-to-be-more-strict branch from aad73c3 to 5862bec Compare October 5, 2023 17:48
@bochaco bochaco added this pull request to the merge queue Oct 5, 2023
Merged via the queue into maidsafe:main with commit c9f3f77 Oct 6, 2023
28 checks passed
@bochaco bochaco deleted the test-gossipsub-to-be-more-strict branch October 6, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Medium Medium sized PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants