Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payment batch size decrease #2546

Closed
wants to merge 2 commits into from
Closed

Payment batch size decrease #2546

wants to merge 2 commits into from

Conversation

mickvandijke
Copy link
Contributor

@mickvandijke mickvandijke commented Dec 17, 2024 •
edited
Loading

Sets max transfers per transaction to 256.

maqi
maqi requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@maqi maqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems the entire data_payments folder can be removed ?

@mickvandijke
Copy link
Contributor Author

seems the entire data_payments folder can be removed ?

Yes, we are not using it anymore

@maqi
Copy link
Member

maqi commented Dec 17, 2024

seems the decreasement is no longer required, due to the smart_contract change.

@mickvandijke mickvandijke force-pushed the payment-batch-size-decrease branch from 5a4633b to caee158 Compare December 17, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maqi maqi maqi requested changes

Assignees
No one assigned
Labels
DoNotMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickvandijke @maqi