Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to address connection errors and rise on adding peers into RT & extra disk writes #2529

Closed

Conversation

maqi
Copy link
Member

@maqi maqi commented Dec 13, 2024

Description

Contains following fixes:

  • not to carry out connection pruning, this is no longer required due to the libp2p upgrades
  • bootstrap node replacement only to be carried out once, as due to the switch to the bootstrap cache, workload is already distributed and could have peers replacing each other.

@maqi maqi force-pushed the not_to_carry_out_connection_cleanup branch from 79ee25a to 96d413b Compare December 13, 2024 19:00
@maqi maqi changed the title chore: not to carry out connection pruning fixes to address connection errors and rise on adding peers into RT & extra disk writes Dec 13, 2024
@maqi maqi force-pushed the not_to_carry_out_connection_cleanup branch from 96d413b to 6294896 Compare December 13, 2024 19:06
@maqi
Copy link
Member Author

maqi commented Dec 13, 2024

The not to prune connection fix has a bad result from staging run, due to the open connections to be kept rise to over 350, compared with previous 72.
Result in a 500% rise on CPU usage as well.
This is due to the libp2p and have to abandon the fix.

The other fix has been moved into PR #2531 to be merged separately.

@maqi maqi closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant