Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat upgradable smart contracts and updated quotation flow rebased #2519

Conversation

grumbach
Copy link
Member

No description provided.

} else {
calculate_cost_for_records(quoting_metrics.close_records_stored)
};
// NB TODO tell happybeing!

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
autonomi/src/client/quote.rs Fixed Show fixed Hide fixed
let payment_verification_results = payment_vault.verify_payment(payment_verifications).await?;

for payment_verification_result in payment_verification_results {
// TODO we currently fail on a single invalid payment, maybe we should deal with this in a different way

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
evmlib/src/transaction.rs Fixed Show fixed Hide fixed
evmlib/src/transaction.rs Fixed Show fixed Hide fixed
evmlib/src/transaction.rs Fixed Show fixed Hide fixed
@grumbach
Copy link
Member Author

rebased version of #2497
@jacderida this one replaces the above one (New Quoting) It'd be good to have this merged in for RC

@grumbach grumbach enabled auto-merge December 11, 2024 07:43
…ts-and-updated-quotation-flow-rebased

Feat upgradable smart contracts and updated quotation flow rebased
…pgradable-smart-contracts-and-updated-quotation-flow-rebased

# Conflicts:
#	ant-node/src/error.rs
…ts-and-updated-quotation-flow-rebased

merge main
let metrics: Vec<_> = metrics.into_iter().map(|v| v.into()).collect();
let mut amounts = self.contract.getQuote(metrics.clone()).call().await?.prices;

// FIXME: temporary logic until the smart contract gets updated

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
let mut rate_limiter = RateLimiter::new();

for (content_addr, raw_quotes) in raw_quotes_per_addr {
// FIXME: find better way to deal with paid content addrs and feedback to the user

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
…rt-contracts-and-updated-quotation-flow-rebased

# Conflicts:
#	Cargo.lock
#	ant-evm/src/data_payments.rs
#	ant-networking/src/cmd.rs
#	ant-networking/src/record_store.rs
#	ant-networking/src/record_store_api.rs
…ts-and-updated-quotation-flow-rebased

rebase
@jacderida jacderida disabled auto-merge December 12, 2024 18:22
@jacderida jacderida merged commit 7f28a5a into maidsafe:main Dec 12, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants