feat: add more logs to autonomi and evmlib #2447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermineJose
force-pushed
the
feat_add-more-logs-autonomi-evmlib
branch
from
30f7431 to
a4214aa
Compare
ermineJose
force-pushed
the
feat_add-more-logs-autonomi-evmlib
branch
2 times, most recently
from
b428a2c to
d072959
Compare
ermineJose
changed the title
ermineJose
force-pushed
the
feat_add-more-logs-autonomi-evmlib
branch
2 times, most recently
from
9e41b73 to
dcf8786
Compare
ermineJose
force-pushed
the
feat_add-more-logs-autonomi-evmlib
branch
from
dcf8786 to
177faa1
Compare
ermineJose
force-pushed
the
feat_add-more-logs-autonomi-evmlib
branch
from
177faa1 to
3726299
Compare
| @@ -93,13 +93,15 @@ impl Archive { | |||
| .as_secs(); | |||
| meta.modified = now; | |||
| self.map.insert(new_path.to_path_buf(), (data_addr, meta)); | |||
| debug!("File renamed successfully in the archive"); | |||
There was a problem hiding this comment.
Could we add context here, i.e., add in the vars old_path and new_path?
Suggested change
| debug!("File renamed successfully in the archive"); | |
| debug!("File renamed successfully in the archive, old path: {old_path:?} new path: {new_path:?}"); |
| Ok(()) | ||
| } | ||
|
|
||
| /// Add a file to a local archive | ||
| /// Note that this does not upload the archive to the network | ||
| pub fn add_file(&mut self, path: PathBuf, data_addr: DataAddr, meta: Metadata) { | ||
| self.map.insert(path, (data_addr, meta)); | ||
| debug!("Added file successfully to the archive"); |
There was a problem hiding this comment.
Could we add more context here?
| @@ -176,6 +176,7 @@ impl Client { | |||
| .await | |||
| .inspect_err(|err| error!("Error uploading chunk {address:?} :{err:?}")) | |||
| }); | |||
| debug!("Finished preparing upload tasks"); | |||
There was a problem hiding this comment.
This would not be useful as we're just pushing tasks to a vec.
| @@ -218,26 +220,33 @@ impl Client { | |||
| info!("Getting chunk: {addr:?}"); | |||
|
|
|||
| let key = NetworkAddress::from_chunk_address(ChunkAddress::new(addr)).to_record_key(); | |||
|
|
|||
| debug!("Converted chunk address to network record key: {:?}", key); | |||
There was a problem hiding this comment.
This is trivial and cannot fail too. It is not required to tell that we've obtained the key. Instead the key can be used in other places to track a particular data on the network. For eg., debug!("Record fetched from network: {:?}", key);
| let get_cfg = GetRecordCfg { | ||
| get_quorum: Quorum::One, | ||
| retry_strategy: None, | ||
| target_record: None, | ||
| expected_holders: HashSet::new(), | ||
| is_register: false, | ||
| }; | ||
| debug!("GetRecordCfg created: {:?}", get_cfg); |
There was a problem hiding this comment.
Trivial and can be removed.
|
|
||
| let record = self | ||
| .network | ||
| .get_record_from_network(key, &get_cfg) | ||
| .await | ||
| .inspect_err(|err| error!("Error fetching chunk: {err:?}"))?; | ||
| debug!("Record fetched from network: {:?}", record); |
There was a problem hiding this comment.
We should not log record as it will be pure Bytes and unreadable. You should probably log the key or address here
| let header = RecordHeader::from_record(&record)?; | ||
|
|
||
| debug!("Record header created: {:?}", header); |
There was a problem hiding this comment.
Trivial and can be removed.
| @@ -98,7 +98,7 @@ impl Client { | |||
| let local = !peers.iter().any(multiaddr_is_global); | |||
|
|
|||
| let (network, event_receiver) = build_client_and_run_swarm(local); | |||
|
|
|||
| debug!("Client is built and swarm driver initiated"); | |||
There was a problem hiding this comment.
Trivial and can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds more tracebility to autonomi and evmlib. Assists in adding more logs for better debugging.
Related Issue
Fixes #<issue_number> (if applicable).
Type of Change
Please mark the types of changes made in this pull request.
Checklist
Please ensure all of the following tasks have been completed: