fix(launchpad): megabits #2420
Merged
fix(launchpad): megabits #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolandSherwin
approved these changes
Nov 9, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
Revert "Merge pull request #2420 from mazzi/fix_stats_mbits"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We fixed a but where we were using the current outbound/inbound metric to calculate << who knows what >>.
Now we use
Mbitsand we use outbound_ratio/inboud_ratio for it over a certain period of time (NODE_STAT_UPDATE_INTERVAL).We use 5 digits because its unlikely for many folks to have 10Gbps, but its extremely rare for one to have 100Gbps, so maybe 00000 without decimal is best. Between >= 1 and <= 99999 Mbps
Thanks Shu!
We also modified a small alignment on the footer, but will be changed shortly.