feat(auditor): recognize payment forwards with default key #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grumbach
reviewed
Jun 10, 2024
Comment on lines
362
to
+365
| } else { | ||
| // check with default key | ||
| if let Some(default_user_name_hash) = | ||
| spend.reason().get_sender_hash(&DEFAULT_PAYMENT_FORWARD_SK) |
There was a problem hiding this comment.
We could reduce indentation and remove the return statement below with an else if let
Suggested change
| } else { | |
| // check with default key | |
| if let Some(default_user_name_hash) = | |
| spend.reason().get_sender_hash(&DEFAULT_PAYMENT_FORWARD_SK) | |
| // check with default key | |
| } else if let Some(default_user_name_hash) = | |
| spend.reason().get_sender_hash(&DEFAULT_PAYMENT_FORWARD_SK) |
And put the unknown participant block in a last else
grumbach
approved these changes
Jun 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
recognize payment forwards with default key
Related Issue
Fixes #<issue_number> (if applicable).
Type of Change
Please mark the types of changes made in this pull request.