feat(networking): allow disabling relay server #1856
Conversation
| @@ -95,6 +97,7 @@ impl NodeBuilder { | |||
| root_dir: PathBuf, | |||
| owner: Option<String>, | |||
| #[cfg(feature = "upnp")] upnp: bool, | |||
| relay_server: bool, | |||
There was a problem hiding this comment.
I think this need not be passed as an arg to NodeBuilder::new(). Since this is a builder, we can add a function inside NodeBuilder to set the value. And then call it if necessary?
There was a problem hiding this comment.
The same should've been done for owner arg :( can we create a commit for that as well if possible?
|
So I think f5475df might be a better approach? Keep it in, but exclude bootstrap nodes? That's make for a more natural "discovery", while also removing the need for many different builds? If we do still want to disable bootstrapping, perhaps we can instead limit capacity? (And perhaps perhaps we need to blacklist repeat requesters? 🤷 ) Thoughts? |
|
They are both two different ways of solving the problem of overloading the bootstrap nodes. I do think there is value in adding this feature though. Maybe there will be people running very CPU-constrained nodes and turning off the relay server might be a first sensible step. On the other hand, a random node shouldn't be totally overwhelmed by relay requests. Maybe another thing to look at is being able to configure the amount of relay requests we accept and possibly limit it to only 2-4 peers that can be using us as relay at the same time. (For resource constrained nodes.) |
I think this is the path we likely need to take. This way all nodes can act as relays (otherwise folk will opt-out; later we should enforce this) Going to close this in favour of that approach for now. |
No description provided.