Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager): don't fetch peers from network-contact file #1851

Merged

Conversation

RolandSherwin
Copy link
Member

@RolandSherwin RolandSherwin commented Jun 6, 2024

  • Currently, the launchpad uses PeersArgs to optionally accept --peers or SAFE_PEERS env variable, but it had the network-contacts feature turned on for sn_peers_acquistion. This means that when you launch the TUI normally, the bootstrap peers were obtained from the contacts file and were being hard-coded inside the service definition file.
  • This is bad because, if there is a change in the network-contacts file (say our original bootstrap peers crashed), then the services started with the hardcoded values will have no way to contact the updated boostrap peers.
    • They'd fail to connect
  • Also, it is bad because service definition file might not sometimes support a large list of values. This might have been a reason for some nodes not being started.

Changes:

  • Modified the manager to not get the network-contact peers

For future PR:

@RolandSherwin RolandSherwin force-pushed the dont_hard_code_network_contacts_peers branch from e73ee40 to cd6e2a7 Compare June 6, 2024 09:01
@joshuef joshuef added this pull request to the merge queue Jun 7, 2024
Merged via the queue into maidsafe:main with commit 3bc50d2 Jun 7, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants