feat(manager): don't fetch peers from network-contact file #1851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PeersArgs
to optionally accept--peers
orSAFE_PEERS
env variable, but it had thenetwork-contacts
feature turned on forsn_peers_acquistion
. This means that when you launch the TUI normally, the bootstrap peers were obtained from the contacts file and were being hard-coded inside the service definition file.network-contacts
file (say our original bootstrap peers crashed), then the services started with the hardcoded values will have no way to contact the updated boostrap peers.Changes:
network-contact
peersFor future PR:
network-contacts
feature fromnode-launchpad
. This would require making some tweaks tosn_peers_acquistion
to expose a function there. This Allow safenode-manager's nat detection command to use the default server list URL #1800 is related.