Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launchpad): enable user to reset nodes #1837

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

RolandSherwin
Copy link
Member

  • Enables the user to reset all the node services and clear the data.


"<Ctrl-r>": {"HomeActions":"TriggerResetNodesPopUp"},
"<Ctrl-R>": {"HomeActions":"TriggerResetNodesPopUp"},
"<Ctrl-Shift-r>": {"HomeActions":"TriggerResetNodesPopUp"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three combinations?

Copy link
Member Author

@RolandSherwin RolandSherwin Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Ctrl-Shift-r is just for a fall back. I'm not sure if it even works, i.e, some might think that [Ctrl+R] in the docs/footer might refer to capital R. So they'd try to perform ctrl + shift + r. It is just for that. It might just work without that, I haven't tested it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same pattern for the other keybinds.
It might be worth checking and cleaning that up later!

Copy link
Contributor

@mazzi mazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@RolandSherwin RolandSherwin enabled auto-merge June 4, 2024 14:23
@RolandSherwin RolandSherwin added this pull request to the merge queue Jun 4, 2024
@RolandSherwin RolandSherwin removed this pull request from the merge queue due to a manual request Jun 4, 2024
@RolandSherwin RolandSherwin force-pushed the tui_reset branch 2 times, most recently from d91bee2 to d51ef5c Compare June 4, 2024 14:55
@RolandSherwin RolandSherwin enabled auto-merge June 4, 2024 15:08
@RolandSherwin RolandSherwin force-pushed the tui_reset branch 2 times, most recently from 2523ea2 to f0edf9a Compare June 4, 2024 15:11
@RolandSherwin RolandSherwin added this pull request to the merge queue Jun 4, 2024
Merged via the queue into maidsafe:main with commit 2849220 Jun 4, 2024
39 checks passed
@RolandSherwin RolandSherwin deleted the tui_reset branch June 4, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants