fix(transfer): mismatched key shall result in decryption error #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqi
changed the title
maqi
force-pushed
the
cypher_decrption_check
branch
2 times, most recently
from
b28a4b3 to
9804dea
Compare
maqi
changed the title
grumbach
reviewed
Jun 4, 2024
| let mut checksum = [0; CHECK_SUM_SIZE]; | ||
| checksum.copy_from_slice(&bytes[CONTENT_SIZE..LIMIT_SIZE]); | ||
| if checksum != CHECK_SUM { | ||
| return Err(TransferError::UserNameDecryptFailed); |
There was a problem hiding this comment.
Since there's no decryption here, we can straight away report that the key is invalid?
Suggested change
| return Err(TransferError::UserNameDecryptFailed); | |
| return Err(TransferError::InvalidDecryptionKey); |
maqi
force-pushed
the
cypher_decrption_check
branch
from
9804dea to
c17ea91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes #<issue_number> (if applicable).
Type of Change
Please mark the types of changes made in this pull request.