feat(launchpad): read stats from metrics endpoint #1821
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| eq(ServiceInstallCtx { | ||
| args: vec![ | ||
| OsString::from("--rpc"), | ||
| OsString::from("127.0.0.1:8081"), |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note test
| @@ -19,8 +19,8 @@ | |||
| const METRICS_CONTENT_TYPE: &str = "application/openmetrics-text;charset=utf-8;version=1.0.0"; | |||
|
|
|||
| pub(crate) fn run_metrics_server(registry: Registry, port: u16) { | |||
| // The server should not bind to localhost/127.0.0.1 as it will not accept connections from containers. | |||
| let addr = ([0, 0, 0, 0], port).into(); | |||
| // todo: containers don't work with localhost. | |||
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
| async fn fetch_stat_per_node(metrics_port: u16, _data_dir: PathBuf) -> Result<NodeStats> { | ||
| let now = Instant::now(); | ||
|
|
||
| let body = reqwest::get(&format!("http://localhost:{metrics_port}/metrics")) |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
|
It's not clear to me if this alone will result in us not having metrics on new testnets. If that's the case I don't want this in until we can have that (via checkbox or what have you at deploy time... default to yes in the workflow trigger) |
safenode manager addlocalhostinstead of0.0.0.0for security.wallet_balancevia the metrics endpoint, but it will get to 0 if the reward has been forwarded. So we need to instead track the forwarded rewards separately.forwarded_balanceacross restarts, we need to cache is locally. Else, people would see a value of 0 after a restart.