-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(test): impl routing table test #1005
Merged
RolandSherwin
merged 12 commits into
maidsafe:main
from
RolandSherwin:routing_table_test
Nov 27, 2023
Merged
feat(test): impl routing table test #1005
RolandSherwin
merged 12 commits into
maidsafe:main
from
RolandSherwin:routing_table_test
Nov 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolandSherwin
force-pushed
the
routing_table_test
branch
3 times, most recently
from
November 23, 2023 17:33
ad2207f
to
e059e43
Compare
maqi
approved these changes
Nov 23, 2023
RolandSherwin
force-pushed
the
routing_table_test
branch
from
November 24, 2023 10:19
e059e43
to
bd534cf
Compare
RolandSherwin
force-pushed
the
routing_table_test
branch
from
November 24, 2023 10:23
bd534cf
to
f5e446e
Compare
RolandSherwin
force-pushed
the
routing_table_test
branch
4 times, most recently
from
November 24, 2023 16:39
1c35aa6
to
1a81f67
Compare
RolandSherwin
force-pushed
the
routing_table_test
branch
from
November 24, 2023 17:03
1a81f67
to
abf4976
Compare
RolandSherwin
force-pushed
the
routing_table_test
branch
from
November 24, 2023 17:48
a4a9ae5
to
aec3ede
Compare
maqi
approved these changes
Nov 25, 2023
maqi
requested changes
Nov 25, 2023
RolandSherwin
force-pushed
the
routing_table_test
branch
from
November 26, 2023 18:38
30fbd37
to
f9b1a35
Compare
RolandSherwin
force-pushed
the
routing_table_test
branch
from
November 26, 2023 19:20
f9b1a35
to
cddcb7f
Compare
maqi
reviewed
Nov 27, 2023
maqi
approved these changes
Nov 27, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 23 Nov 23 16:57 UTC
This pull request includes the following changes:
In the file
rpc_service.rs
:k_buckets_response
in thesafenode_proto
module.k_buckets
for handling the RPC request forKBucketsRequest
.record_addresses
method to return a response containing addresses.In the file
msgs_over_gossipsub.rs
:HashMap
andHashSet
.get_kbuckets
method that returns a map of ilog2 distance of the Kbucket to the peers in that bucket.RunningNode
struct implementation with the new methodget_kbuckets
.get_kbuckets
.self.network.get_kbuckets().await?
in theget_kbuckets
method.subscribe_to_topic
method signature to take aString
parameter instead of a&str
.In the file
lib.rs
:get_kbuckets
to theNetwork
struct. This method returns a map of ilog2 distance of the Kbucket to the peers in that bucket.get_kbuckets
method uses a channel to communicate with the swarm and fetches the map of Kbucket distances. If there is an error in receiving the result, it returns anInternalMsgChannelDropped
error.In the file ".github/workflows/merge.yml":
timeout-minutes
value for the step "Verify the Routing table of the nodes" to 5 minutes.timeout-minutes
value for the step "Verify the location of the data on the network" to 5 minutes.In the file "req_resp_types.proto":
KBucketsRequest
,KBucketsResponse
, and a nested messagePeers
withinKBucketsResponse
.In the file "common.rs":
get_all_peer_ids
,NODE_COUNT
, andPAYING_WALLET_INITIAL_BALANCE
.NodeIndex
fromu8
tou32
.get_all_peer_ids
function and its implementation.verify_location
function to use theget_all_peer_ids
function directly rather than importing it.get_all_peer_ids
function.CHUNK_COUNT
constant.CHURN_COUNT
constant.NodeIndex
fromu8
tou32
in theRecordHolders
type alias.verify_location
function toResult<()>
.get_all_peer_ids
function definition.get_all_peer_ids
function call to use a direct URL string rather than formatting it.println!
statement in theget_all_peer_ids
function.store_chunks
function.wallet_dir
parameter in thestore_chunks
function.Please let me know if you need further assistance with this pull request.