-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add behaviour measures #197
Conversation
I think you'll have to update the Rust version for the CI to run: Line 10 in 30a1274
|
|
||
/// An archive for storing individuals between operators, e.g. for subsequent calculation of measures. | ||
#[derive(Default, Tid)] | ||
pub struct IntermediateArchive<P: Problem + 'static>(Vec<Individual<P>>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would maybe be nicer to add a Archive<I: Identifier>
struct that is used by all archive components that require a Vec<Individual>
, but I think this is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remember this for a later improvement PR.
I think once it passes the CI, we're ready to merge. |
Could you please take a look at the last error in the CI (@Saethox)? I did not change anything there and I don't understand what's wrong. |
Seems to be a clippy bug: rust-lang/rust-clippy#12788 Looks like we either need to downgrade our clippy version or remove the |
We could also allow |
True, that's an easier option. Probably needs to be module-wide on |
Added those behaviour measures which seem most important at the moment.
Possibly there are some (or rather many) improvements to be made to the way I implemented them, so please tell me what you think should be changed.