Do some renaming and refactors #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename Population to Populations and rename some methods - Make State generic over the problem type - Switch initialization order of condition in Loop
luleyleo
approved these changes
Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PopulationtoPopulations.State, most notablypopulation_stacktopopulations.Stategeneric over the problem type, sobest_individualand such don't need a type annotation.These were some changes that I think are more elegant that came up when writing the Tech Report. Making
Stategeneric might sound unintuitive because it doesn't actually depend onPaside from the convenience methods, but I think those are important enough that omitting the type parameter there is more intuitive. It also integrated quite nicely with logging, so there's that. When writing the Python wrapper, I actually needed to wrapStateinto a wrapper that is generic overPanyway, so that was a first indicator that this might be more elegant.