Make heuristics usable as components #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeleNoir
reviewed
Aug 22, 2022
Saethox
changed the title
HeleNoir
approved these changes
Aug 29, 2022
luleyleo
requested changes
Aug 30, 2022
Comment on lines
+30
to
+32
| pub fn into_builder(self) -> ConfigurationBuilder<P> { | ||
| ConfigurationBuilder::new().do_(self.0) | ||
| } |
There was a problem hiding this comment.
Is this useful? I can't really come up with a good use case because you could only append to the end, but not within the loop.
There was a problem hiding this comment.
I agree that this method might only be used in rather obscure cases, but I figured that an elegant way to append to existing configurations could not hurt.
Comment on lines
+155
to
+156
| /// Size of the initial population. | ||
| pub initial_population_size: Option<u32>, |
There was a problem hiding this comment.
These initialization methods implement both Initialization and Generation, either pushing a new population with initial_population_size on the stack, or regenerating an existing population with a certain size. In the latter use case, no initial_population_size is needed.
luleyleo
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98, Closes #97
Changes
All heuristics in the
heuristicsmodule now have a generic template function with the same name as the module (e.g.,heuristics::aco::aco), which is not specific to a certain problem (parametrized overSingleObjectiveProblem). They accept aheuristics::<heuristic_name>::Parametersstruct with their specific components and parameters, aterminationcriterion and aLogger.The existing heuristics were converted into
real_<heuristic_name>orpermutation_<heuristic_name>functions etc., depending on the problem type they solve, and now use their specific template method internally. They each have their own*Parametersstruct.The heuristic templates make it possible to have heuristics nested within other heuristics, e.g., the
real_iterated_local_searchuses thereal_local_searchconfiguration internally.