Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup project structure #102

Merged
merged 12 commits into from
Jul 23, 2022
Merged

Cleanup project structure #102

merged 12 commits into from
Jul 23, 2022

Conversation

luleyleo
Copy link
Collaborator

Cleaning up the project structure before I rewrite the documentation for #96 .

@luleyleo luleyleo changed the title WIP: Cleanup project structure Cleanup project structure Jul 22, 2022
@luleyleo luleyleo requested a review from Saethox July 22, 2022 15:02
@luleyleo
Copy link
Collaborator Author

@Saethox I think this makes MAHF's structure a bit more intuitive. If you have further suggestions, please let me know.

@Saethox
Copy link
Collaborator

Saethox commented Jul 22, 2022

Looks good to me, and some of these changes are much needed. I think we can merge after the CI passes.

And if we are already refactoring: the SimpleEvaluator should in my opinion also live in its own module, and be renamed to something like SequentialEvaluator. But I can handle this in #95, as I will have to touch the code anyway there.

On another note, I don't like the way the problem::tsp module is organized (coming from the person who wrote it), so I'd really like to refactor it, but this is really not the most pressing problem. But I will probably add an issue.

@Saethox
Copy link
Collaborator

Saethox commented Jul 22, 2022

I think this PR also closes #99.

@luleyleo luleyleo merged commit 67c2a2e into master Jul 23, 2022
@luleyleo luleyleo deleted the cleanup-modules branch July 23, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants