Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For recordings with frame > (2 ** 31 - 1), data type of two variables in in prepare_spikesortingview_data need to change from np.int32 to np.int64. #229

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

donghoon-shin
Copy link
Contributor

For recordings with frame > 2**31 - 1 (about 29.8h recording with Fs=20000), num_frames should be in np.int64

and spike_train should have elements in np.int64.

I changed these variables to have data type of np.int64 only when recording.get_num_frames() > (2 ** 31 - 1).

I tested this version for two 2.64 days recordings one sorted with scheme3 with block_size = a day, and the other one with scheme2.

@magland
Copy link
Owner

magland commented Jan 15, 2024

Awesome, thanks!

@magland magland merged commit 015612c into magland:main Jan 15, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants