Skip to content

Commit

Permalink
Revert "transient-{set,save,reset}: Stay transient"
Browse files Browse the repository at this point in the history
This reverts commit 361d8ac.

The goal of that commit was to ensure that the transient stays
active when invoking one of these commands.

However both of these pre-commands are supposed to do that, so while
moving from one to the other, did seem to address that issue,
something else must be going on, which will have to be investigated
(including why `transient--do-call' only misbehaves for these suffix
commands in combination of certain prefix commands).

More importantly though, this commit has to be reverted because it
introduced a regression, which is worse than the minor defect it fixed.
These commands depend on variables being exported.  The only intended
difference between the two pre-commands is that `transient--do-call'
exports variables, so switching to `transient--do-stay' made no sense.

Closes #257.
  • Loading branch information
tarsius committed Sep 19, 2023
1 parent b150b48 commit 7c08beb
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lisp/transient.el
Original file line number Diff line number Diff line change
Expand Up @@ -1625,9 +1625,9 @@ of the corresponding object."
"<transient-show>" #'transient--do-stay
"<transient-update>" #'transient--do-stay
"<transient-toggle-common>" #'transient--do-stay
"<transient-set>" #'transient--do-stay
"<transient-save>" #'transient--do-stay
"<transient-reset>" #'transient--do-stay
"<transient-set>" #'transient--do-call
"<transient-save>" #'transient--do-call
"<transient-reset>" #'transient--do-call
"<describe-key-briefly>" #'transient--do-stay
"<describe-key>" #'transient--do-stay
"<transient-scroll-up>" #'transient--do-stay
Expand Down

0 comments on commit 7c08beb

Please sign in to comment.