feat: Text Underline added
#203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HydenLiu is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey @HydenLiu love what you did here! Would be really valuable addition. If you can figure out a way to address this glitching when I hover in the middle of animation then i'll merge it in :) Screen.Recording.2024-08-06.at.1.55.55.PM.mov |
|
@dillionverma Thanks for the reply, I fixed this problem, hope I didn't misunderstand you! |
HydenLiu
force-pushed
the
feat/text-underline
branch
from
a48c629 to
81b676e
Compare
|
It's nice one @dillionverma , @HydenLiu , is there a way to choose between underline or highlighting (background)? |
|
Hey @HydenLiu, the glitch hasn’t been fixed - it’s still the same as Dillion shows in the video. When I hover quickly, it creates a very bad and glitchy effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, can I add this component? here's the result
I'm looking forward to your feedback and hope this can be a valuable contribution.