refactor: 채팅을 웹소켓으로 교체한다 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheonjiyun
force-pushed
the
feature/#137
branch
from
e4d762a to
a7864fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
Game에서 웹소켓이랑 함수들을 다 관리하고 있습니다. recoil로 관리가 안된다고 하네요. 그래서 한 컴포넌트안에서 다 관리해주었습니다.
구독이나 채팅보내는 함수들을 props로 내려서 함수를 실행했습니다.
Game에 코드가 너무 길어져서 관련 함수들만 따로 관리하거나 클래스를 만들어서 분리하고 싶네요. 일단 돌아가는 게 우선이니까 리팩토링은 다음에 하겠습니다.
contents -> content로 변경
close #137