fix : Game save 조건 추가 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
바달(바보 달리라는 뜻) |
thdwoqor
approved these changes
Aug 11, 2024
| @@ -15,6 +15,6 @@ public Status getNextStatus(Game room, Long now) { | |||
|
|
|||
| @Override | |||
| public StatusType getType() { | |||
| throw new RoomException(ExceptionCode.DELETED_STATUS); | |||
| return StatusType.WAIT; | |||
There was a problem hiding this comment.
DeletedStatus.getType에 반환값을 주고 (Wait) 이거 면 저장 로직에서 제외시켜 주었습니다.
반환값이 StatusType.Deleted 만들어서 Deleted 상태이면 저장하지 않게하는게 이해하기 편할꺼같아
Deleted 상태 값을 반환하는데 Wait이 나오는게 조금 어색한거같아
There was a problem hiding this comment.
아 그게 더 나을려나 난 WaitStatus로 이름을 바꿀까 생각했었는데... 생각해보면 Game의 Delete니까 그게 더 맞을꺼란 생각도 들고... 오키
fix : Delete 상태시 반환 Type 추가
kpeel5839
approved these changes
Aug 11, 2024
waterricecake
added a commit
that referenced
this pull request
Oct 14, 2024
* fix : Game save 조건 추가 * fix : Delete 상태시 반환 Type 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
문제 원인 :
EndStatus.getNextStatus를 하면서 game delete 이벤트를 발행 하는데 이때 return으로 다음 상태를 주면서 snapshot의 Status 상태와 달라져서 save가 일어남나게 되었습니다.
이 때문에 예외처리하는 상태가 저장되게 되면서 (원래는 지워졌어야할) 계속 예외처리를 하게 되는 오류였습니다.
DeletedStatus.getType에 반환값을 주고 (Wait) 이거 면 저장 로직에서 제외시켜 주었습니다.
ps. 이벤트 랑 레디스 때문에 진짜 돌려보면 생기는 버그가 많네요;;;;이번엔 이것도 직접 QA해봤습니다 진짜임