feat: 결과 조회 기능 구현 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waterricecake
approved these changes
May 18, 2024
| if(!room.isEnd()){ | ||
| throw new RoomException(ExceptionCode.GAME_IS_NOT_FINISHED); | ||
| } | ||
| return RoomResultResponse.of((EndStatus) room.getStatus()); |
There was a problem hiding this comment.
다운캐스팅 조금 아쉽긴한데 그렇지 않으면 내부의 함수를 room으로 빼야해서 또 room의 역할이 너무 커지네;;;
Comment on lines
+21
to
+53
| public static EndStatus create(final List<Player> players, final Long now) { | ||
| return new EndStatus(players, now, now + ONE_MINUTE); | ||
| } | ||
|
|
||
| public JobType getWinnerJob() { | ||
| if(getAliveMafia()==0){ | ||
| return JobType.CITIZEN; | ||
| } | ||
| return JobType.MAFIA; | ||
| } | ||
|
|
||
| private Map<Boolean, List<Player>> partitionPlayersByRole() { | ||
| return players | ||
| .stream() | ||
| .collect(Collectors.partitioningBy(Player::isMafia)); | ||
| } | ||
|
|
||
| public List<Player> getWinner() { | ||
| Map<Boolean, List<Player>> players = partitionPlayersByRole(); | ||
|
|
||
| if (getAliveMafia() == 0) { | ||
| return players.get(Boolean.FALSE); | ||
| } | ||
| return players.get(Boolean.TRUE); | ||
| } | ||
|
|
||
| public List<Player> getLoser() { | ||
| Map<Boolean, List<Player>> players = partitionPlayersByRole(); | ||
|
|
||
| if (getAliveMafia() == 0) { | ||
| return players.get(Boolean.TRUE); | ||
| } | ||
| return players.get(Boolean.FALSE); |
There was a problem hiding this comment.
room에서 이 역할들을 해주면 room의 역할이 너무 커지니까 status내부로 옮긴건가? room 역할 줄인건 좋은데 다운캐스팅을 하면 추상화한게 좀 아쉬워지는 느낌이라 지양하고 싶긴한데
waterricecake
pushed a commit
that referenced
this pull request
May 20, 2024
* feat: 게임이 끝나지않았을때 예외 추가 * feat: 게임 결과 반환 기능 구현
waterricecake
pushed a commit
that referenced
this pull request
Oct 14, 2024
* feat: 게임이 끝나지않았을때 예외 추가 * feat: 게임 결과 반환 기능 구현
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EndStatus에서 결과를 반환할수있게 구현했고 처음에는 Room을 상태로 가지고있었다가 Room 전체를 필요로하지않고 테스트가 매우 힘들어져서 List를 가지는 방향으로 변경함...
더좋은 방법있으면 리뷰 부탁...