방 추가 상태 기능 구현 #43
Merged
방 추가 상태 기능 구현 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thdwoqor
reviewed
May 16, 2024
| @@ -17,121 +17,118 @@ class StatusTest { | |||
|
|
|||
| private static final ZoneId TIME_ZONE = ZoneId.of("UTC"); | |||
| private static final Clock roomCreatedTime = Clock.fixed(Instant.parse("2024-01-01T00:00:00.000000Z"), TIME_ZONE); | |||
| private static final Clock dayIntroEndTime = Clock.fixed(Instant.parse("2024-01-01T00:00:02.000000Z"), TIME_ZONE); | |||
There was a problem hiding this comment.
@Getter
@RequiredArgsConstructor
public abstract class Status {
protected final Timestamp startTime;
protected final Timestamp endTime;
}생각해보면 프론트에서 2024-01-01T00:00:02.000000Z
이런 날짜가 필요한게아닌거같아서 Timestamp 말고 long 형식에
unix timestamp 사용하면 계산하기도 편할거같은데 어떻게 생각?
There was a problem hiding this comment.
오 잘모르는 거긴한데 한번 공부해보고 올께
| @@ -7,9 +7,9 @@ | |||
|
|
|||
| public class EndStatus extends Status { | |||
|
|
|||
| public static final Long UNIT = 60000L; | |||
| public static final Long UNIT = 59999L; | |||
There was a problem hiding this comment.
네이밍 1M 이나 1MINUTE 이 보기편할꺼같은데 어떰
There was a problem hiding this comment.
단위로 생각해서 UNIT으로 하긴 했는데 시간을 의미하는게 들어가는게 좋긴하겠네 근데 1M이나 1MINUTE으로 안한건 뭔가 그 상태에서 쓰이는 단위시간의 의미로 넣은거라 단위의 의미가 들어갔음 좋겠는데;;;
thdwoqor
approved these changes
May 17, 2024
| @@ -23,7 +23,8 @@ public String create( | |||
| while (rooms.containsKey(code)) { | |||
| code = CodeGenerator.generate(); | |||
| } | |||
| rooms.put(code, Room.create(roomInfo, Clock.systemDefaultZone())); | |||
| final Long now = Clock.systemUTC().millis(); | |||
There was a problem hiding this comment.
API 바뀌는거라 프론트랑 이야기 해야할거같긴한데
이게 밀리세컨드 기준으로 사용하냐 초단위로 사용하냐에따라서 길이가 달라져서 초단위로 사용할꺼면
Instant.now().getEpochSecond()이거 써야하긴한데 일단 OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42
순서
WAIT (600초)
DAY_INTRO (3초)
NOTICE (3초)
DAY (플레이어 * 20초)
VOTE (10초)
VOTE_RESULT (3초) | END (60초)
NIGHT_INTOR (3초)
NIGHT (40초)
WAIT (600초) | END (60초)
로 구현함