feat : 어그리거트 정의에 따른 네이밍 반영 및 API 수정 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpeel5839
approved these changes
Aug 24, 2024
| public void startGame(final String code) { | ||
| final Lobby lobby = lobbyRepository.findById(code) | ||
| .orElseThrow(() -> new GameException(ExceptionCode.INVALID_NOT_FOUND_ROOM_CODE)); | ||
| Game game = Game.create(lobby, Clock.systemDefaultZone().millis()); |
There was a problem hiding this comment.
| // job | ||
| @GetMapping("/rooms/night/result") | ||
| public ResponseEntity<RoomNightResultResponse> findNightResult( | ||
| @GetMapping("/jobs/skill/result") |
There was a problem hiding this comment.
|
|
||
| private final int total; | ||
| private final int mafia; | ||
| private final int doctor; | ||
| private final int police; | ||
|
|
||
| public static RoomInfo of(final int total, final int mafia, final int doctor, final int police) { | ||
| public static LobbyInfo of(final int total, final int mafia, final int doctor, final int police) { | ||
| if (total / 2 < mafia || total < 3 || mafia == 0) { |
There was a problem hiding this comment.
이런 것들은 따로 메서드로 빼서 의미를 명확하게 할 수 있을 것 같아요. ex) isInvalidRoleBalnace 등등.. 있을 것 같아요
There was a problem hiding this comment.
waterricecake
added a commit
that referenced
this pull request
Oct 14, 2024
* refactor : Room -> Lobby 어그리거트 명 수정 * feat : Lobby API 수정 * feat : Game API 수정 * feat : Jobs API 수정 * feat : Vote API 수정 * test : 수정된 API 따른 test API 수정 * refactor : Job 패키지명에 따른 네이밍 수정 * refactor : 패키지 명 변경에 따른 네이밍 수정 * refactor : 불필요한 주석 제거 * feat : gameStart url 변경 * fix : 밤 결과 url 수정 * style : 코드 컨벤션 적용 * refactor : 직업 검증 로직 분리
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #102
해당 Issue PR 인데 이거 어프루브되도 나중에 프론트 URL 바뀔때 머지해야할것 같습니다