Skip to content
This repository has been archived by the owner on Jun 2, 2019. It is now read-only.

Fixed possible cyclic dep when used with other modules #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pulquero
Copy link

"cwd => '/opt'" implies that /opt should exist, so there should be an explicit file {'opt':}. This fixed some cyclic dep hell for me.

"cwd     => '/opt'"  implies that /opt should exist, so there should be an explicit file {'opt':}. This fixed some cyclic dep hell for me.
@carlossg
Copy link
Member

carlossg commented Jul 9, 2015

I don't think it is needed, from https://docs.puppetlabs.com/references/latest/type.html#exec

If Puppet is managing an exec’s cwd or the executable file used in an exec’s command, the exec resource will autorequire those files

but it doesn't say that the dir needs to be defined, and the tests are passing without it

I'm reluctant to add new dir creation because even inside ! defined the order will matter

@jyaworski
Copy link

Possibly simpler solution:

Can we just use /tmp as the cwd, and mkdir -p if we really need it to be /opt?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants